[analyzer] don't mark non-final instance fields as pure (fixes #9029)

src/optimization/analyzerTexpr.ml

@@ -1213,7 +1213,7 @@ module Purity = struct
 		taint node;
 		raise Exit
 
-	let apply_to_field com is_ctor c cf =
+	let apply_to_field com is_ctor is_static c cf =
 		let node = get_node c cf in
 		let check_field c cf =
 			let node' = get_node c cf in
@@ -1233,8 +1233,9 @@ module Purity = struct
 					taint_raise node
 			end
 		and loop e = match e.eexpr with
-			| TMeta((Meta.Pure,_,_),_) ->
-				()
+			| TMeta((Meta.Pure,_,_) as m,_) ->
+				if get_purity_from_meta [m] = Impure then taint_raise node
+				else ()
 			| TThrow _ ->
 				taint_raise node;
 			| TBinop((OpAssign | OpAssignOp _),e1,e2) ->
@@ -1269,6 +1270,8 @@ module Purity = struct
 		match cf.cf_kind with
 			| Method MethDynamic | Var _ ->
 				taint node;
+			| _ when not (is_static || is_ctor || has_class_field_flag cf CfFinal) ->
+				taint node
 			| _ ->
 				match cf.cf_expr with
 				| None ->
@@ -1287,9 +1290,9 @@ module Purity = struct
 						()
 
 	let apply_to_class com c =
-		List.iter (apply_to_field com false c) c.cl_ordered_fields;
-		List.iter (apply_to_field com false c) c.cl_ordered_statics;
-		(match c.cl_constructor with Some cf -> apply_to_field com true c cf | None -> ())
+		List.iter (apply_to_field com false false c) c.cl_ordered_fields;
+		List.iter (apply_to_field com false true c) c.cl_ordered_statics;
+		(match c.cl_constructor with Some cf -> apply_to_field com true false c cf | None -> ())
 
 	let infer com =
 		Hashtbl.clear node_lut;

tests/server/src/Main.hx

@@ -265,6 +265,18 @@ class ServerTests extends HaxeServerTestCase {
 		Assert.isTrue(messages.exists(message -> r.match(message)));
 	}
 
+	function testIssue9029_analyzer_preventPurityOnOverridden() {
+		vfs.putContent("Main.hx", getTemplate("issues/Issue9029/Main.hx"));
+		vfs.putContent("Game.hx", getTemplate("issues/Issue9029/Game.hx"));
+		vfs.putContent("Screen.hx", getTemplate("issues/Issue9029/Screen.hx"));
+		var args = ["-main", "Main", "-D", "analyzer-optimize", "--interp"];
+		runHaxe(args);
+		vfs.putContent("Game.hx", getTemplate("issues/Issue9029/Game.hx.modified"));
+		runHaxeJson([], ServerMethods.Invalidate, {file: new FsPath("Game.hx")});
+		runHaxe(args);
+		assertSuccess();
+	}
+
 	// function testIssue8616() {
 	// 	vfs.putContent("Main.hx", getTemplate("issues/Issue8616/Main.hx"));
 	// 	vfs.putContent("A.hx", getTemplate("issues/Issue8616/A.hx"));

tests/server/test/templates/issues/Issue9029/Game.hx

@@ -0,0 +1,5 @@
+class Game extends Screen {
+	override function onStart() {
+		// trace(123);
+	}
+}

tests/server/test/templates/issues/Issue9029/Game.hx.modified

@@ -0,0 +1,5 @@
+class Game extends Screen {
+	override function onStart() {
+		trace(123);
+	}
+}

tests/server/test/templates/issues/Issue9029/Main.hx

@@ -0,0 +1,5 @@
+class Main {
+	static function main() {
+		final game = new Game();
+	}
+}

tests/server/test/templates/issues/Issue9029/Screen.hx

@@ -0,0 +1,7 @@
+class Screen {
+	public function new() {
+		onStart();
+	}
+
+	function onStart():Void {}
+}