[hl/eval/cpp/neko] Fix exception stack when wrapping native exceptions #11249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11247 (caused by #10519), where auto wrapped exceptions on eval/hl/neko/cpp were missing their first entry, removed automatically by all
haxe.Exception
subclasses' constructor (__shiftStack
call added by compiler itself) while we don't want it in this case.Current implementation is hacky; an alternative could be to handle that directly in
filters/exceptions.ml
but I'm not sure how to proceed there.This should also cover #10926, but since there was no issue/test for the commit that introduced the issue, it's hard to say if this covers everything from it.
Closes #10926
Added a related fix, closes #11265