Don't allow sibling class access to private constructor #6957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand why we check for |
|
Probably doesn't make a difference anymore, I'll remove it. |
bendmorris
force-pushed
the
private-constructor
branch
from
90ed3b6
to
39b99f4
Compare
Gama11
added a commit
to openfl/openfl
that referenced
this pull request
Apr 19, 2018
Gama11
added a commit
to HaxeFlixel/flixel
that referenced
this pull request
Apr 19, 2018
Gama11
added a commit
to HaxeFlixel/flixel-demos
that referenced
this pull request
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5871
A private constructor should only be accessible in the class or its direct descendants.
Found one of these in the tests themselves, so I'm sure people have been relying on this, knowingly or not.