Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] js.html externs refer deprecated js.Promise type #8282

Open
nadako opened this issue May 13, 2019 · 4 comments
Open

[js] js.html externs refer deprecated js.Promise type #8282

nadako opened this issue May 13, 2019 · 4 comments
Assignees
@haxiomic
Labels
feature-html-externs HTML externs for platform-js platform-javascript Everything related to JS / JavaScript priority-low
Milestone
Later

Comments

@nadako
Copy link
Member

nadako commented May 13, 2019

Try compiling for JS with --macro include("js.html") and you see some deprecation warnings due to externs using unqualified Promise access which resolves to js.Promise, which is now deprecated. The externs should import js.lib.Promise or specify the full path.
@nadako nadako added platform-javascript Everything related to JS / JavaScript priority-low feature-html-externs HTML externs for platform-js labels May 13, 2019
@nadako nadako added this to the Release 4.0 milestone May 13, 2019
@haxiomic haxiomic mentioned this issue May 13, 2019
Open
8 tasks
RealyUniqueName added a commit that referenced this issue May 13, 2019
@RealyUniqueName
[js] change Promise references in js.html to js.lib.Promise (#8282)
c694332
@Aurel300
Copy link
Member

This was fixed with c694332

@Gama11
Copy link
Member

Gama11 commented May 27, 2019

I don't think so, I think that was a direct modification of the generated externs as a temporary workaround? The extern generator would still need to be updated.

@RealyUniqueName
Copy link
Member

Yes. I fixed directly to get rid of warnings and left this issue open because of extern generator is not updated.

@haxiomic haxiomic removed this from the Release 4.0 milestone Aug 8, 2019
@haxiomic
Copy link
Member

haxiomic commented Aug 8, 2019

I've removed this from 4.0 because the only issue now is in the generator and it shouldn't block 4.0

@RealyUniqueName RealyUniqueName added this to the Release 4.1 milestone Aug 9, 2019
@Simn Simn modified the milestones: Release 4.1, Release 4.2 Feb 19, 2020
@RealyUniqueName RealyUniqueName modified the milestones: Release 4.2, Backlog Dec 14, 2020
@Simn Simn modified the milestones: Backlog, Later Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haxiomic haxiomic

Labels
feature-html-externs HTML externs for platform-js platform-javascript Everything related to JS / JavaScript priority-low
Projects
None yet
Milestone
Later
Development

No branches or pull requests
6 participants
@nadako @Simn @Aurel300 @Gama11 @RealyUniqueName @haxiomic