Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js] js.html.push.PushSubscriptionOptionsInit is missing userVisibleOnly field #9027

Open
nadako opened this issue Dec 12, 2019 · 2 comments
Open

[js] js.html.push.PushSubscriptionOptionsInit is missing userVisibleOnly field #9027

nadako opened this issue Dec 12, 2019 · 2 comments
Assignees
@haxiomic
Labels
feature-html-externs HTML externs for platform-js platform-javascript Everything related to JS / JavaScript
Milestone
Later

Comments

@nadako
Copy link
Member

nadako commented Dec 12, 2019

userVisibleOnly: A boolean indicating that the returned push subscription will only be used for messages whose effect is made visible to the user.

It's a bit annoying because this field is actually required currently in e.g. Chrome.
@nadako nadako added platform-javascript Everything related to JS / JavaScript feature-html-externs HTML externs for platform-js labels Dec 12, 2019
@nadako
Copy link
Member Author

nadako commented Dec 12, 2019

It's commented out in the IDL for some reason: https://github.com/HaxeFoundation/html-externs/blob/52a15145a2b036c389b422a7d694a90aaa7a66dd/webidl/mozilla/PushManager.webidl#L11

mockey pushed a commit to mockey/haxe that referenced this issue Dec 12, 2019
@RealyUniqueName
[js] add parens to compound exprs passed to Syntax.code() (fixes Haxe…
3b23395 
…Foundation#9027)
@haxiomic haxiomic mentioned this issue Dec 12, 2019
Open
8 tasks
@haxiomic
Copy link
Member

Seems to be commented out in the latest IDLs too
https://github.com/mozilla/gecko-dev/blob/master/dom/webidl/PushManager.webidl#L11

When I do the next html-externs update I will patch it in manually

@RealyUniqueName RealyUniqueName added this to the Backlog milestone Dec 13, 2019
RobDangerous pushed a commit to Kode/haxe that referenced this issue Dec 21, 2019
@RealyUniqueName
[js] add parens to compound exprs passed to Syntax.code() (fixes Haxe…
7900dbe 
…Foundation#9027)
@Simn Simn modified the milestones: Backlog, Later Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haxiomic haxiomic

Labels
feature-html-externs HTML externs for platform-js platform-javascript Everything related to JS / JavaScript
Projects
None yet
Milestone
Later
Development

No branches or pull requests
4 participants
@nadako @Simn @RealyUniqueName @haxiomic