[js] Generate export with @:expose and -D js-es=6 #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
changed the title
Also add support for export default
kLabz
changed the title
kLabz
commented
Dec 19, 2020
| match args with | ||
| | [ EConst (String("default",_)), _ ] -> print ctx "export default "; | ||
| | [] -> print ctx "export "; | ||
| | _ -> abort "Invalid @:expose parameters" pos |
There was a problem hiding this comment.
Not sure what to do in this case, since @:export('something') was valid until now and still has some use here.
Maybe this feature would be better with a @:export meta instead?
There was a problem hiding this comment.
I think @:expose('CustomName') class Test{} should be generated as class Test {}; export {Test as CustomName}
|
This I guess what we want nowadays is something like |
|
Glad that things are moving here..! :-) |
|
Hello all, I'd like to contribute to moving this forward. It's not clear to me from this message thread what this PR is missing to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8033
Edit: hmm this doesn't work with the closure
-D js-classic?