Disallow case string interpolation #10496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
reviewed
Nov 21, 2021
| | String (value,kind) when kind = Ast.SSingleQuotes -> | ||
| let e = ctx.g.do_format_string ctx value p in | ||
| begin match e with | ||
| | EBinop _, p -> typing_error "String interpolation is not allowed in case patterns" p; |
There was a problem hiding this comment.
I'm surprised that '$foo' becomes a binop... But I suppose it's fine to rely on that and if we ever change it we can just update the check here in some way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe complex string interpolation expression should be generated here with
do_format_stringcall, but typing cannot be called easily without refactoring (recursive dependency)?Closes #9163