Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua: Minimal implementation of ssl #10593

Merged
merged 5 commits into from
Mar 8, 2022
Merged

Conversation

jaimeMF
Copy link
Contributor

@jaimeMF jaimeMF commented Feb 17, 2022

Depends on luasec.
The initial implementation is enough to access a webpage over https.

@jaimeMF
Copy link
Contributor Author

jaimeMF commented Feb 22, 2022

I have added the installation of luasec in the test environment, but it doesn't compile in Mac OS because it can't find openssl/ssl.h.

@skial skial mentioned this pull request Feb 23, 2022
1 task
Depends on luasec.
The initial implementation is enough to access a webpage over https.
brew doesn't allow it. Instead we pass the OPENSSL_DIR option to luarocks.
@jaimeMF
Copy link
Contributor Author

jaimeMF commented Mar 3, 2022

I have managed to install luasec by installing openssl with brew and passing the OPENSSL_DIR option to luarocks.

@Simn
Copy link
Member

Simn commented Mar 3, 2022

Hmm, it's funny that we depend on OpenSSL here because all other targets (I think) depend on Mbed TLS. But if that's how things are done in Lualand, we'll have to make due.

Can we still use non-SSL sockets without installing luasec?

@jaimeMF
Copy link
Contributor Author

jaimeMF commented Mar 3, 2022

Can we still use non-SSL sockets without installing luasec?

I have tried with --dce full and if you just use sys.net.Socket it doesn't require the luasec package, but using haxe.Http requires it. I should probably modify the condition on haxe.Http to take into account the lua_vanilla flag.

@jaimeMF
Copy link
Contributor Author

jaimeMF commented Mar 7, 2022

I have added a commit to not pull in luasec when using the lua-vanilla flag.

@Simn Simn merged commit e1ced88 into HaxeFoundation:development Mar 8, 2022
@Simn
Copy link
Member

Simn commented Mar 8, 2022

Thank you for the contribution!

@jaimeMF jaimeMF deleted the lua-ssl branch March 8, 2022 21:13
@skial skial mentioned this pull request Mar 9, 2022
1 task
@tobil4sk tobil4sk mentioned this pull request Aug 19, 2022
tobil4sk added a commit to tobil4sk/HaxeManual that referenced this pull request Apr 2, 2023
tobil4sk added a commit to tobil4sk/HaxeManual that referenced this pull request Apr 5, 2023
Simn pushed a commit to HaxeFoundation/HaxeManual that referenced this pull request Apr 5, 2023
* Update bit dependency docs for lua

Lua 5.1 requires installing bit32 manually. [0]

Lua 5.2 provides bit32 natively. [1]

Lua 5.3 still has it natively, though it is deprecated in favour of
native operators. [2]

Lua 5.4 removes this library from the standard installation, so it must
be installed again. [3]

[0]  HaxeFoundation/haxe#10923
[1] https://www.lua.org/manual/5.2/manual.html#6.7
[2] http://www.lua.org/manual/5.3/manual.html#8.2
[3] http://www.lua.org/manual/5.4/manual.html#3.4.2

* Add luasec dependency

HaxeFoundation/haxe#10593

* Remove environ dependency

HaxeFoundation/haxe@9d75bec

* Add hx-lua-simdjson dependency

HaxeFoundation/haxe#9885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants