Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Context.withImports #10602

Merged
merged 10 commits into from Feb 28, 2022
Merged

Implement Context.withImports #10602

merged 10 commits into from Feb 28, 2022

Conversation

Simn
Copy link
Member

@Simn Simn commented Feb 23, 2022

See #10537

Still have to add API dorkumentation.

@back2dos I've changed the API to use Array<String> for both because that's easier to use. Is there any reason it shouldn't be like that?

@back2dos
Copy link
Member

I guess I based my suggestion on get:LocalImports() and getLocalUsing(), but turning the returned data into strings is easy enough, if that's where the user gets the data from. Otherwise just chucking in strings is definitely more convenient ;)

@back2dos
Copy link
Member

Oh, I was also curious to know if * imports (or imports of modules with statics) will shadow vars (and current fields with implicit this / TheClass) or not? Not that I lean in any particular direction, but I'd say it's the kind of thing that should be specified one way or the other ;)

@Simn
Copy link
Member Author

Simn commented Feb 23, 2022

Resolution order will behave as if these were normal imports.

@skial skial mentioned this pull request Feb 24, 2022
1 task
@Simn Simn merged commit 1f7de73 into development Feb 28, 2022
@Simn Simn deleted the with_imports branch February 28, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants