More Lambda inlines #11148
Open
More Lambda inlines #11148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
reviewed
Apr 14, 2023
| let rec traverse arg_num args types meta = | ||
| match (args, types, meta) with | ||
| | (arg :: args, (arg_name, optional, t) :: types, arg_meta :: meta) -> | ||
| let unsafe_argument = contains_unsafe_meta arg_meta in | ||
| let unsafe_argument = contains_unsafe_meta arg_meta || expr_with_unsafe_meta arg in |
There was a problem hiding this comment.
Why do you need that?
Couldn't you just do if (@:nullSafety(Off) f(v)) ? (which also happens to be at least somewhat readable)
There was a problem hiding this comment.
This will disable null safety for inlined function code, see:
final f = [1, 2, null, 3].find(item -> {
item++; // should error
item == 2;
});Current change only casts argument type instead.
There was a problem hiding this comment.
😕 this both feels a bit hacky on compiler side and very ugly on haxe side imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes passed function allocations by default, which seems better to me, than 5-6 more generated lines instead of Lambda call?
If this is too much, for some reason, i can only keep internal early returns changes to make
inline arr.find(...)work.There is also little null safety hack around #11077