Account for sub-types in ComplexTypeTools.toComplex().
#11273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding the two failed checks, one seems to be a download issue, and I have no idea what the other means. But CI worked over on my repo (after one retry), so I assume it's transient. |
|
Checking |
|
|
Ah you're right, in that case this seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you pass
"package.Module.SubType"you'll getTPath({ pack: ["package", "Module"], name: "SubType" }). After this change, you'll instead getTPath({ pack: ["package"], name: "Module", sub: "SubType" }).Resolves #8342.
Apparently this was first brought up in 2014, but not resolved because the implementation was too complex (no pun intended). Hopefully this is better!