[js] Update Object and Symbol externs #11331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
force-pushed
the
fix/js-object-sign
branch
from
492f166
to
2a9a5f2
Compare
From their implementation in js-object haxelib
kLabz
force-pushed
the
fix/js-object-sign
branch
from
2a9a5f2
to
2a6a84d
Compare
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* [js] Update js.lib.Object and js.lib.Symbol From their implementation in js-object haxelib * Restore ?field syntax * Reduce diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging implementation from js-object and current std
Main change is changing
Object.assignto allow returning an object of a different type than input object, because that's a possibility and is actually often used (adding fields is one current use case, but replacing a field can be useful too, and might change a field's type (which isn't great in Haxe...).