Improve inline constructor handling of 'if', 'try' and 'while' expressions. #11356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds special cases for
if
try
andwhile
expressions in the constructor inliner logic allowing for the body of those expressions to result in an inlined object with the condition that the expressions themselves are ignored (not assigned to a variable or passed as argument to some other function)Example of code that used to cancel inlining but now works:
A scenario where you'd encounter this problem is when you have a function that does some side effect and then returns an inline object. Even if the inline object was not used, just by being present at the end of an if or while block it would cause the inlining to cancel.
This could be worked around by changing the body of the if to result in a noop:
With this PR that work around is no longer needed.