Instance builder cleanup #11376
Merged
Instance builder cleanup #11376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/typing/typeload.ml
|
This turned into a big |
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* change return of build_instance to record * also rename * also seperate * also bring back typedef deprecation check * alsp keep special cases in the right place * mess around * avoid some work if we need no params anyway * make @:generic inference work again * remove Generic_Exception * push expected type before loading instance closes HaxeFoundation#3864 * expand generic types on field call candidate when expanding generic function closes HaxeFoundation#5482 * build generic parents as well closes HaxeFoundation#6761 * inherit `@:autoBuild` to generic instance closes HaxeFoundation#5536 * also inherit @:keepSub while we're at it closes HaxeFoundation#6500 * deal with KExpr in generic classes properly closes HaxeFoundation#7574 * don't inherit cf_expr_unoptimized to generic instances closes HaxeFoundation#9358 * reroute FClosure in map_expr_type closes HaxeFoundation#9395 * inherit cl_using to generic instances closes HaxeFoundation#10528 * set inherited flags on generic instance fields at the right time closes HaxeFoundation#11010 * I really don't care * wild guess * avoid the follow change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR so I don't forget about branches. This attempts to clean up our type instance loading and reduce some code duplication. The goal is to have
type_newandload_instanceuse the same mechanism instead of doing their own thing. This should also fix some related issues that I'll have to dig up, in particular things related totypedefand@:generic.Currently makes #11367 worse (and consistent) which is why the test for #2016 is commented out. Will look into that kind of stuff before merging.Closes #3864
Closes #5482
Closes #5536
Closes #6500
Closes #6761
Closes #7574
Closes #9358
Closes #9395
Closes #10528
Closes #11010
Closes #11367