add support for --undefine foo to remove define
#11400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That note makes me wonder if we should use something else instead... |
|
Not sure what else, though. |
|
How do real compilers deal with this? |
|
I suspect they don't allow |
|
I'm very willing to just break that. |
kLabz
changed the title
-D !foo to remove define--undefine foo to remove define
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
* add support for -D !foo to remove define * use long syntax only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that on unix, outside hxml files we need to escape with single quotes (so-D '!foo')Short syntax isn't worth it