Don't create a class field for every enum field #11452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They only exist so that type_field can find them easily, but it might as well just check the constructors, which it already does anyway.
# Conflicts: # src/typing/typeloadModule.ml
0b1kn00b
pushed a commit
to 0b1kn00b/haxe
that referenced
this pull request
Jan 25, 2024
…on#11452) They only exist so that type_field can find them easily, but it might as well just check the constructors, which it already does anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think I ever really realized that we create a full
tclass_fieldfor everytenum_fieldjust so we can build aTAnonfrom it, and we only do that so that one lookup canPMap.findon its fields. That seems a bit pointless, so I'd like to change it.I happen to maintain a library that broke with this change because it was actually looking at the anon fields, so there's potential for some friction here. But that should be well within reason.