Remove some global state #11483
Merged
Remove some global state #11483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only thing this governs is whether or not we set macro_interp_cache, and I don't see why we would ever not want to set for a given compilation.
This isn't read anywhere. Perhaps I removed something accidentally... but in that case, nobody seems to be missing it.
I have no idea why I didn't do that in the first place and instead wrote that essay...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used a very elaborate regex to find some global state and remove it, either by actually removing it or absorbing it into a context.
I'll merge this unsquashed so we can bisect if something goes wrong.