Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've come across a problem with the current way we handle anon fields and anons. Those are encoded on first use, which is convenient because in the general case anon fields might need type parameters from the local context. This works fine if the reader reads everything in order, but with delayed expression reading there can be the following situation:
It would be good to have an isolated test case for this, but it's not very easy to find one because this only occurred in a substantial codebase and is affected by the intricacies of type loading.
With this PR we now distinguish between anon fields that require a local context and those that don't. The former are still written immediately, which should work fine because such abstracts cannot appear elsewhere anyway. The latter are stored in the OFD chunk which is then read separately, which should always work because no local context is required. By extension, this applies to anons and the OBD chunk.