Pretty errors as default message reporting #11587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kLabz
changed the title
kLabz
changed the base branch from
unify_help_messages_handling
to
development
kLabz
force-pushed
the
default_message_reporting
branch
from
9caacc8
to
193c13a
Compare
|
Let's go I guess? The earlier we do it, the more time we have to handle things getting bad because of it |
|
Please update the branch to make sure we didn't add any breaking tests in the meantime. Afterwards I'm fine with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #11584, changes default error reporting mode to "pretty".
Our misc (and display) tests don't like this change. I dodged it for now, but if we're switching default message reporting we might want something cleaner there?