Don't bind foreign type parameters in definition mode #11658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Things look ok so far, will test more this afternoon Edit:
|
|
Seems to be fine :) |
|
I thought you'd come across a case from #11624 in the wild because I thought that's where those came from, but I won't complain! |
|
Either that problem was probably fixed on user code since I opened the issue, or that was a report from a private project. Either way, it doesn't seem to be a common thing :) |
|
Apparently there's such case in tink: https://try.haxe.org/#2D89fEF9 (this PR still isn't available on try haxe) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
linkso that it no longer binds monomorphs to type parameters that are not known in the current context. For now we're only doing this in the new definition mode.This likely breaks some code.
Closes #11624