as3 Compile Error #6179
Closed
as3 Compile Error #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error when targeting as3. Generates NativePropertyIterator.as and NativeValueIterator.as but __foreach__ __forin__ missing. Better to not generate at all, since those impl are not used.
Error when targeting as3. Generates NativePropertyIterator.as and NativeValueIterator.as but __foreach__ __forin__ missing. Better to not generate at all, since those impl are not used.
Simply inlined all heavily used operations
|
Added an optimization to SHA256 by adding inline |
|
Please don't mix unrelated changes in one PR like that. What exactly fails here? Could you add a test case for that? |
|
I can't add a test case since the target (as3) compile process is developer specific. This is a compile error in as3 when it discovers .as files with the missing _foreach call. Sorry about the collation of the SHA256 change. Don't really use github and it collated that pull request with the other two. Is there a way to force a separate pull req? |
|
Simn, I'm going to close this pull and attempt a retry with two separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl on as3 target creates unneeded impl classes that fail as3 compilation. Made those conditional if not as3