add TEnumIndex and make matcher generate that instead of Type.enumIndex call #6364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
TEnumIndex of texpr
node and makes pattern-matcher generate it instead ofType.enumIndex
call, as well as adds handling of that node to target generators. Adding this introduced some optimizations that eliminated a couple switches on some targets, also surfacing #6352 on C# (disabled the test for now).I didn't remove older enum index hacks and Type.enumIndex for now, and there's no way to generate
TEnumIndex
from haxe code right now, soType.enumIndex
implementations are duplicated. I tried to add matching onEnumValueTools.getIndex()
and using that forType.enumIndex
but that loses the enum expression type making itEnumValue
instead, so this is something we have to think about.Also, I have to check out the diffs again, but creating this PR nevertheless so Travis can show if everything is okay.