Properly represent final on classes and fields
#7381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also hold back on the warnings because the Flash API has `@:final` everywhere
|
One extra refactoring that might be worth is to store booleans into a single bit flag (cf_public/cf_extern/cf_final) : it will save a few bytes of memory per class field which is quite good, and also allows us to add additional flags without breaking macros etc. Same remark for tclass |
Gama11
added a commit
to vshaxe/haxe-language-server
that referenced
this pull request
Sep 6, 2018
kLabz
pushed a commit
to kLabz/haxe-languageserver
that referenced
this pull request
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests
final classandfinalon fields by properly representing it incf_final.I've decided to do this properly instead of juggling
@:finalmetadata around. This means some macros might have to adapt.See #6584