[std] Move target.vm.Thread (and friends) to sys.thread.Thread #7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm keeping the typedefs in std for now because it conveniently also deals with the hxcpp build tool problem. Last thing to do is make this fail on non-threaded targets. We have to be a bit careful with ImportAll/dox in that regard. |
std/sys/thread/Deque.hx
Outdated
| package sys.thread; | ||
|
|
||
| #if (!target.threaded) | ||
| #error "This target is not available on this target" |
back2dos
pushed a commit
to back2dos/haxe
that referenced
this pull request
Oct 5, 2021
…oundation#7999) * [std] move all thread classes to sys.thread * [neko] add @:coreApi * [cpp] add @:coreApi * [java] add @:coreApi * [std] purge redundant documentation * [std] document Deque and Lock * [tests] fix java.vm leftovers * [std] add deprecation typedefs * [std] fix Tls * [std] fix Deque * [typer] error if we access sys.thread on non-threaded target * [std] nobody saw that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves types neko.vm.Thread to sys.thread.Thread. It also adds
@:coreApito the neko, cpp and java classes. It does not add@:coreApifor HL and eval because their interfaces are not 100% compatible. I consider this a separate (non-)issue though.This currently breaks the hxcpp build tool because it relies on neko.vm.Thread. This raises the question of deprecation strategy. We can add typedefs to hx3compat, or to std itself. I think we should fix the hxcpp build tool independently.
TODO