New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py] Fix #8197 #8340

Merged

Simn merged 1 commit into HaxeFoundation:development from Aurel300:issue/8197

May 28, 2019

Member

Aurel300 commented May 27, 2019 •

edited

Prior to this PR, when using Sys.stdout().writeString(...) with a Unicode string:

string is encoded into a UTF-8 byte array
the byte array is iterated byte by byte
each byte is written separately via String.fromCharCode
any byte over 127 is re-encoded by Python into UTF-8 (so 0x80 turns into the incorrect 0xC2 0x80)

Test for this is part of #8135 .


          don't write strings byte-by-byte (fix HaxeFoundation#8197)

201845b

Aurel300 requested a review from frabbit

May 27, 2019 16:56

RealyUniqueName added this to the Release 4.0 milestone

skial mentioned this pull request

Haxe Roundup 481 skial/haxe.io#622

Closed

1 task

Simn merged commit 96cacb8 into HaxeFoundation:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment