[wip] Negative startIndex in String.indexOf() #8370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seeing the test results this is not 4.0 priority. |
Simn
added
the
waiting-for-feedback
|
Branch needs an update. |
…tartIndex # Conflicts: # std/cs/internal/StringExt.hx # std/java/internal/StringExt.hx
|
The tests added here fail even on JS. Both JS and Java define a negative start index as working like 0, so if anything that's what we should conform to. |
|
... which also means I might as well close this PR because neither the tests nor the changes bring us closer to any existing specification. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8365
We have targets, which don't follow this spec (quote from
String.indexOf()doc):Also we don't have any spec about negative
startIndexonString.lastIndexOf()