[wip] Handle infinite recursion in Std.string()
#8377
+82
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RealyUniqueName
changed the title
Std.string()Std.string()
|
Could you update the branch please? |
|
It is standard behavior in other languages to throw a Stack Overflow Exception when, for instance, trying to stringify a self-referencing object. I don't see why this is bug, nor why this should be "fixed"... But whatever, if this were to be implemented, the default recursion limit should DEFINITELY be much higher than 5. |
Simn
added
the
waiting-for-feedback
|
Getting stack overflows from recursive value printing is not a good user experience. We should definitely account for that. As for the limit, I agree that the 5 is a bit low. We can increase that and maybe make it configurable through a define. Also, the branch needs an update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6728