Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js] Add js.lib.Number #8465

Closed
wants to merge 3 commits into from
Closed

Conversation

terurou
Copy link
Member

@terurou terurou commented Jun 22, 2019

No description provided.

@Gama11
Copy link
Member

Gama11 commented Jun 22, 2019

Hm.. I wonder if there should be an abstract wrapper around this for implicit casts and such, with the actual extern being a private class NumberImpl or similar?

@terurou
Copy link
Member Author

terurou commented Jun 23, 2019

@Gama11 Thanks for your review.
I changed to use abstract.

@skial skial mentioned this pull request Jun 24, 2019
1 task
@Simn Simn added this to the Release 4.1 milestone Aug 17, 2019
@Simn Simn added the waiting-for-feedback We need more information to deal with this issue. label Feb 17, 2020
@Simn
Copy link
Member

Simn commented Feb 17, 2020

Please update this PR to see what the CI is doing.

@RealyUniqueName
Copy link
Member

js.lib.Number should probably be a @:coreType abstract instead of using extern private class as an underlying type.

@Simn Simn modified the milestones: Release 4.1, Release 4.2 Apr 29, 2020
@RealyUniqueName RealyUniqueName modified the milestones: Release 4.2, Backlog Feb 2, 2021
@Simn
Copy link
Member

Simn commented Apr 11, 2022

There hasn't been any update here, so at this point I'll close this PR.

@Simn Simn closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-for-feedback We need more information to deal with this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants