Completion item filtering #8642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is going on... the tests fail in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps track of completion "subjects" and filters the results accordingly if they exceed a certain number. The filter works by treating types with lower priority under the assumption that they are the only completion item kind which could realistically hit the limit. This may or may not require some more thought and design, but should work fine in practice.
I can't really show fancy comparison screenshots because there are no reliable timers, given that the bulk of the slowdown occurred somewhere in vshaxe. I promise it's much, much faster though.
Filters are implemented as case-insensitive string list comparisons, so that
h.d.Mmatcheshaxe.ds.Mapand such.Closes #8639.