Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endless recursion in Class_obj::GetInstanceFields #1027

Merged
merged 1 commit into from Mar 27, 2023

Conversation

profelis
Copy link
Contributor

@profelis profelis commented Feb 5, 2023

cpp::Pointer.mSuper points to same cpp::Pointer instance

Steps to reproduce:

  1. get this repo and build debug sample https://github.com/foreignsasquatch/raylib-hx/tree/main/examples
  2. add breakpoint inside while loop https://github.com/foreignsasquatch/raylib-hx/blob/main/examples/BasicWindow.hx#L12
  3. start debugger session in vscode

stacktrace
https://gist.github.com/profelis/390f80bc47afc16f41b3afced4896cc6

cpp::Pointer.mSuper points to same cpp::Pointer instance
@Simn
Copy link
Member

Simn commented Mar 27, 2023

I don't really understand how a pointer relation like this happens in the first place, but this kind of check is usually a good idea anyway, so I'm happy to merge it.

@Simn Simn merged commit 09ffa29 into HaxeFoundation:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants