Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map toString brackets #892

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Map toString brackets #892

merged 1 commit into from
Mar 31, 2023

Conversation

RblSb
Copy link
Member

@RblSb RblSb commented Mar 14, 2020

Changes brackets style in maps for HaxeFoundation/haxe#9260

@hughsando
Copy link
Member

Is the intention here to have Map display differently from Dynamic ?
If you want to restrict it to a particular version (eg, haxe 4.1) there is going to need to be some conditional-compiling in the c++ code.

@RealyUniqueName
Copy link
Member

The intention is to have Map display the same as in Haxe syntax: [key => value]

@Simn
Copy link
Member

Simn commented Mar 26, 2023

Hmm yeah, updating hxcpp should not cause any printing changes on Haxe versions < 4.3.

@Simn
Copy link
Member

Simn commented Mar 31, 2023

This looks good to me now that everything is hidden behind an API check.

@Simn Simn merged commit 96f5f9a into HaxeFoundation:master Mar 31, 2023
@RblSb RblSb deleted the map_tostring branch March 31, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants