Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pdf_path cannot be without a trailing slash #459

Merged
merged 6 commits into from
Jun 18, 2020
Merged

fix pdf_path cannot be without a trailing slash #459

merged 6 commits into from
Jun 18, 2020

Conversation

senwu
Copy link
Collaborator

@senwu senwu commented Jun 17, 2020

Description of the problems or issues

Does your pull request fix any issue.
Closes #442

Description of the proposed changes

Use the same method _get_linked_pdf_path to check the pdf file in is_linkable and link in VisualLinker.

Test plan

Test various doc_path and pdf_path formats.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.rst accordingly.

@senwu senwu requested a review from lukehsiao June 17, 2020 10:09
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #459 into master will increase coverage by 0.03%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   83.22%   83.25%   +0.03%     
==========================================
  Files          88       88              
  Lines        4559     4562       +3     
  Branches      837      836       -1     
==========================================
+ Hits         3794     3798       +4     
  Misses        572      572              
+ Partials      193      192       -1     
Flag Coverage Δ
#unittests 83.25% <93.75%> (+0.03%) ⬆️
Impacted Files Coverage Δ
src/fonduer/parser/visual_linker.py 84.18% <93.33%> (+0.22%) ⬆️
src/fonduer/parser/parser.py 92.94% <100.00%> (ø)
...c/fonduer/parser/preprocessors/doc_preprocessor.py 88.09% <0.00%> (+2.38%) ⬆️

Copy link
Contributor

@HiromuHota HiromuHota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.
I left a few minor comments.

src/fonduer/parser/parser.py Outdated Show resolved Hide resolved
src/fonduer/parser/visual_linker.py Show resolved Hide resolved
@senwu senwu merged commit 62f1cd4 into master Jun 18, 2020
@senwu senwu deleted the fix/442 branch June 18, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf_path cannot be without a trailing slash
3 participants