Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity+Speed modifier #26

Merged
merged 15 commits into from
Sep 20, 2017
Merged

Gravity+Speed modifier #26

merged 15 commits into from
Sep 20, 2017

Conversation

WhyFaust
Copy link
Contributor

No description provided.

@WhyFaust WhyFaust changed the title Gravity+Speed mofifier Gravity+Speed modifier Aug 10, 2017
hl_gangs.sp Outdated
@@ -1660,7 +1666,7 @@ public void SQLCallback_Perks(Database db, DBResultSet results, const char[] err
if (!gcv_bDisableSize.BoolValue && gcv_iMaxGangSize.IntValue != 0)
{
price = gcv_iSizePrice.IntValue + (gcv_iPriceModifier.IntValue * ga_iSize[client]);
Format(sDisplayBuffer, sizeof(sDisplayBuffer), "%T [%i/9] [%i %T]", "GangSize", client, ga_iSize[client], price, "Credits", client);
Format(sDisplayBuffer, sizeof(sDisplayBuffer), "%T [%i/gcv_iGangSizeMaxUpgrades] [%i %T]", "GangSize", client, ga_iSize[client], price, "Credits", client);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be gcv_iGangSizeMaxUpgrades.IntValue?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or more precisely
Format(sDisplayBuffer, sizeof(sDisplayBuffer), "%T [%i/%i] [%i %T]", "GangSize", client, ga_iSize[client], gcv_iGangSizeMaxUpgrades.IntValue, price, "Credits", client);

@Headline
Copy link
Owner

Does it's default values match that of the old function?

@WhyFaust
Copy link
Contributor Author

It used to be 0,01~0.02 Now 0,03

@Headline
Copy link
Owner

Headline commented Sep 12, 2017

I'm alright with having OnAvailableLR implemented in this plugin for those who have hosties, but we should also keep in mind that some servers may not be running this plugin. So we have to be careful about how we use this native.

On line 2755 if we keep LastRequest(), but then add OnAvailableLR elsewere and have it call LastRequest(). That way LastRequest() is kept and can be used in the PlayerDeath hook if they're not using hosites (A simple LibraryExists check).

Besides that I'm 👍

@Headline
Copy link
Owner

Thank you!

👍

@Headline Headline merged commit 54dfdaa into Headline:master Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants