Improve boilerplate implementation #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
This is an extension to the boilerplate implementation, we'll see a few things developed on this branch.
This patch will move some of the regex creation to be in the
constants.rs
and prevent regex recompilation after every compilation request, something that we needed to bringlazy_static
in to accomplish.Our end goal is to move function declarations out of main methods, that way functions can be created and moved to their correct places as needed.
We'll need a regex made that allows us to detect function definitions. Unlike our main regexes, we'd need to match functions that could have templated/generic return types. Let's use C++ as an example.
A request in this form should not trip up our detection, so correctly matching any function call regardless of it's return type form might be tricky, we'll have to see.