Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create New Dataset Dialog #780

Merged
merged 15 commits into from
Jul 4, 2024
Merged

Add Create New Dataset Dialog #780

merged 15 commits into from
Jul 4, 2024

Conversation

AndrewThien
Copy link
Contributor

@AndrewThien AndrewThien commented Jul 4, 2024

Changes

This PR added the ShadCN dialog to create a new dataset on the Create Scan Report and Dataset List pages.

Closes #774
Closes #651

Screenshots

  • On the New Scan report page
    Screenshot 2024-07-04 at 09 29 53

  • On the Dataset list page
    Screenshot 2024-07-04 at 09 30 08

Checks

Important: please complete these before merging.

  • Run migrations, if any.
  • Update changelog.md, including migration instructions if any.
  • Run unit tests.

Copy link

github-actions bot commented Jul 4, 2024

Tests Skipped Failures Errors Time
25 1 💤 1 ❌ 0 🔥 4.354s ⏱️

@AndrewThien AndrewThien requested a review from AndyRae July 4, 2024 09:11
app/next-client-app/api/datasets.ts Outdated Show resolved Hide resolved
@AndrewThien AndrewThien requested a review from AndyRae July 4, 2024 09:56
@AndrewThien AndrewThien requested review from AndyRae, dcl10 and Dev-Akashili and removed request for AndyRae July 4, 2024 10:40
@AndrewThien AndrewThien merged commit d9fe871 into master Jul 4, 2024
14 checks passed
@AndrewThien AndrewThien deleted the feat/774/new-dataset branch July 4, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Data Set dialog Creating a new Dataset without assigning it to a Project places it in all Projects
3 participants