Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pagination) page size is set by component before value is able to be bound #776

Closed
joeskeen opened this issue Mar 20, 2019 · 1 comment · Fixed by #1015
Closed

(pagination) page size is set by component before value is able to be bound #776

joeskeen opened this issue Mar 20, 2019 · 1 comment · Fixed by #1015
Assignees
@andrew-frueh
Labels
bug new patch version number to the library released

Comments

@joeskeen
Copy link
Contributor

Describe the bug
If pageSize is two-way bound to a value, the pagination component will revert that value to the default value of 20 before it has a chance to bind the initial value (especially if that value isn't available at ngOnInit, such as query string subscriptions). The result is that no matter what you pick, the value will always go back to 20.
@corykon corykon added the bug new patch version number to the library label Jul 12, 2019
@joeskeen joeskeen added this to High priority in Cashmere Component Backlog Aug 27, 2019
@andrew-frueh andrew-frueh self-assigned this Sep 29, 2019
andrew-frueh added a commit to andrew-frueh/Fabric.Cashmere that referenced this issue Oct 4, 2019
@andrew-frueh
fix(pagination): initial value of pageSize
85e1e69 
stops initial value of pageSize from being overwritten to the default

closes HealthCatalyst#776
andrew-frueh added a commit to andrew-frueh/Fabric.Cashmere that referenced this issue Oct 4, 2019
@andrew-frueh
fix(pagination): initial value of pageSize
73f388d 
stops initial value of pageSize from being overwritten to the default

closes HealthCatalyst#776
@andrew-frueh andrew-frueh mentioned this issue Oct 4, 2019
Merged
Cashmere Component Backlog automation moved this from ⚠️ High priority to Completed Oct 4, 2019
@benjanderson
Copy link
Contributor

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrew-frueh andrew-frueh

Labels
bug new patch version number to the library released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(pagination): initial value of pageSize andrew-frueh/Fabric.Cashmere
4 participants
@benjanderson @joeskeen @corykon @andrew-frueh