fix(pagination): initial value of pageSize #1015
Conversation
stops initial value of pageSize from being overwritten to the default closes HealthCatalyst#776
| @@ -52,6 +52,7 @@ export class BasePaginationComponent extends Initializable implements OnInit { | |||
| set pageSize(value: number) { | |||
| this._pageSize = coerceNumberProperty(value); | |||
| this._pageSizeUpdated(); | |||
| this._emitPageEvent(this.pageNumber); | |||
There was a problem hiding this comment.
🤦♂ I can't believe it was that simple!
There was a problem hiding this comment.
@andrew-frueh looks like you broke some tests though... might want to look into that
corrects behavior of pageNumberChange and pageSizeChange
|
Thank goodness for those unit tests @joeskeen! Turns out that because the two-way binding was broken, we never noticed that the page Thanks for being so thorough when you wrote those!! |
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Stops initial value of pageSize from being overwritten to the default. I starred at this one for hours thinking it had something to do with base class inheritance. Turns out it just had to do with the two-way binding being broken; the pageSize setter wasn't emitting on a change.
closes #776