Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent default spacing between radio buttons vs checkboxes #955

Closed
joeskeen opened this issue Aug 21, 2019 · 1 comment · Fixed by #1012
Closed

Inconsistent default spacing between radio buttons vs checkboxes #955

joeskeen opened this issue Aug 21, 2019 · 1 comment · Fixed by #1012
Assignees

Comments

@joeskeen
Copy link
Contributor

Summary

When you have both radio buttons and checkboxes on a form, it is pretty obvious that the default spacing between them isn't consistent. See this example:

image

        <hc-accordion>
            <hc-accordion-toolbar>One-to-one subsets</hc-accordion-toolbar>
            <hc-checkbox *ngFor="let subset of oneToOneSubsets" [value]="subset.id">{{ subset.name }}</hc-checkbox>
        </hc-accordion>
        <hc-accordion>
            <hc-accordion-toolbar>One-to-many subsets</hc-accordion-toolbar>
            <p>
                Including a one-to-many subset will export the <a href="https://en.wikipedia.org/wiki/Cartesian_product">Cartesian Product</a> of the records to
                their subset records, which can <strong>significantly</strong> increase the file size of the export. It is for this reason that only one
                one-to-many subset may be selected.
            </p>
            <hc-radio-group>
                <hc-radio-button *ngFor="let subset of oneToManySubsets" [value]="subset.id">{{ subset.name }}</hc-radio-button>
            </hc-radio-group>
        </hc-accordion>
@andrew-frueh andrew-frueh self-assigned this Sep 25, 2019
andrew-frueh added a commit to andrew-frueh/Fabric.Cashmere that referenced this issue Sep 28, 2019
adjusts the spacing between radio buttons to match checkboxes

closes HealthCatalyst#955
@benjanderson
Copy link
Contributor

🎉 This issue has been resolved in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants