Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to python 3 #50

Merged
merged 52 commits into from
Feb 16, 2022
Merged

Upgrade to python 3 #50

merged 52 commits into from
Feb 16, 2022

Conversation

HealthyPear
Copy link
Owner

@HealthyPear HealthyPear commented Nov 22, 2021

Summary

  • the interface becomes a python3-based package installable via pip within a conda environment
  • containerization is not required anymore, but material for it has been stored under containers; we should at least support a Docker container
  • heavy usage of logging everywhere possible
  • added some unit-tests
  • existing scripts have been improved and refactored
  • added some new ones, mainly aimed at debugging purposes

@HealthyPear HealthyPear added documentation Improvements or additions to documentation enhancement New feature or request maintenance dependency labels Nov 22, 2021
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #50 (bcd8787) into master (1885526) will decrease coverage by 0.20%.
The diff coverage is 75.00%.

❗ Current head bcd8787 differs from pull request most recent head 9bad6d5. Consider uploading reports for the commit 9bad6d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   21.82%   21.61%   -0.21%     
==========================================
  Files          10       10              
  Lines         747      745       -2     
==========================================
- Hits          163      161       -2     
  Misses        584      584              
Impacted Files Coverage Δ
split_dataset.py 81.25% <75.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1885526...9bad6d5. Read the comment docs.

@HealthyPear HealthyPear linked an issue Nov 23, 2021 that may be closed by this pull request
@HealthyPear HealthyPear marked this pull request as draft November 24, 2021 15:32
- move all material to a dedicated folder
- store here conde environment files, which are now also updated
- directory tree test is skipped until protopipe 0.5.0 is available
- CI has been updated to only support conda-based installation also on
  macos
- yaml needed to be added to the test dependencies
- conda recipes moved back to root folder

Update CI

Add pyyaml as a dependency for testing

Update CI installation

Remove unused import

Fix CI installation order

Test CI  on macos-latest

Try giving CONDA permission to its own files

Update CI

- add macos-latest
- update conda env name

Forgot to unset env name

Use unambiguous conda env name

Import load_config from utils not from protopipe

also skip test that requires new protopipe

leave protopipe import in submit jobs

Test CI only on macos-latest

Test CI only with conda-based installation

Test CI also on ubuntu-latest but only conda
- added an option to disable the upload of the analysis config file
- added a loop to counteract some Dirac issues when splitting input data
- Output type was showing input sandbox
- added protopipe version used at submission
- strip newlines trailing characters from list entries,
- use logging.exception in case list is not found,
- use absolute file path from root directory
- for some reason now fts3 needs to be specified
- python version also specified as in Dirac and CTADIRAC

Update conda envs
@HealthyPear HealthyPear merged commit aac8c8c into master Feb 16, 2022
@HealthyPear HealthyPear deleted the upgrade_python_3 branch February 16, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency documentation Improvements or additions to documentation enhancement New feature or request maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test upgrade to python3
2 participants