Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BoardCard class Titan compatibility #4504

Merged
merged 1 commit into from
Oct 26, 2023
Merged

BoardCard class Titan compatibility #4504

merged 1 commit into from
Oct 26, 2023

Conversation

batstyx
Copy link
Contributor

@batstyx batstyx commented Oct 20, 2023

@batstyx
BoardCard class Titan compatibility
39ca32b 
- Add titan check and titan abilities used count
- Return false from IsAbletoAttack method if card is titan and still has unused abilities
- Issue HearthSim#4503
@batstyx
Copy link
Contributor Author

batstyx commented Oct 20, 2023 •
edited
Loading

This probably needs a silenced check as well, haven't had time to test that yet.

Update: Silence removes TITAN tag, so silenced behaviour is correct as is.

@azeier azeier merged commit b75a0f8 into HearthSim:master Oct 26, 2023
@azeier
Copy link
Member

azeier commented Oct 26, 2023

Thanks for yet another fix!

@batstyx batstyx deleted the damage-counter-titan-compatibility branch October 26, 2023 17:42
KelvinCS pushed a commit that referenced this pull request Nov 6, 2023
@batstyx @KelvinCS
fix: attack counters for Titan cards (#4504)
9a28f28 
- Add titan check and titan abilities used count
- Return false from IsAbletoAttack method if card is titan and still has unused abilities
- Issue #4503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@batstyx @azeier