This repository has been archived by the owner on Jan 21, 2022. It is now read-only.
build: upgrade to TypeScript 4.0 #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zernie
force-pushed
the
build/typescript-4
branch
from
5dd833c
to
f20976a
Compare
fixes "ERROR: 16:2 callable-types Interface has only a call signature — use `type IPlatformConstructable = new () => IPlatform;` instead."
|
@joolean could you please take a look? I know this is a pretty big change, but I'm hoping I could get your opinion |
|
Hello, thanks for wanting to contribute! Unfortunately we no longer actively maintain this project. I would suggest creating your own fork of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades:
rollup-plugin-typescriptwas deprecated, so I've replaced it withrollup-plugin-typescript2. Same goes forrollup-*pluginsNotes:
HTMLCanvasElement, HTMLImageElement, CanvasRenderingContext2Dwere needed to be replaced by their platform-specificCanvas, Image, Contexttypes.