Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Java 11 #44

Closed
ennerf opened this issue Oct 25, 2018 · 3 comments
Closed

Upgrade to Java 11 #44

ennerf opened this issue Oct 25, 2018 · 3 comments

Comments

@ennerf
Copy link
Contributor

ennerf commented Oct 25, 2018

Benefits

  • Smaller binary size due to modularization in Java9. Should reduce binary size from ~80MB to somewhere between 15-25MB
  • Various bugfixes in JavaFX. I don't think there is anything major though that is currently an issue for us. (The Linux native memory leak seems to only depend on the Mesa3D library)
  • Java 11 moved JavaFX into a separate project that isn't bundled with the JDK, which will likely speed up the development cycle.

In order to upgrade, we are mainly waiting for our whole build chain to support the Java9 modularization

  • IntelliJ: some issues, but supported well enough
  • Maven: some issues, but supported well enough
  • ProGuard: Fixed Aug 2018
  • ProGuard Maven plugin: soon?
  • Javapackager Maven plugin: TBD

Development links:

@ennerf ennerf added the enhancement New feature or request label Oct 25, 2018
@ennerf
Copy link
Contributor Author

ennerf commented Nov 9, 2018

Once we upgrade, we can also remove the tooltip hack required for https://stackoverflow.com/a/43291239/3574093

@ennerf
Copy link
Contributor Author

ennerf commented May 13, 2019

It looks like the ProGuard Maven Plugin now has a workaround.

The Javapackager was completely removed from JDK 12, so it'd have to be built with a previous version (e.g. JDK 10 packager executable). With that in mind, it may make sense to remove the maven plugin and to separate out this step so we can finally update.

@ennerf
Copy link
Contributor Author

ennerf commented May 13, 2019

JavaFX 12+ has a new maven plugin and can be used like a library

Getting Started
Maven plugin for javaFX 11+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant