This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
GRW-1392 / feat / Add switching notice for download page #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the font sizes and paddings are larger on the Download page compared to the Offer page
simonauner
force-pushed
the
GRW-1392/feat/add-switching-notice-for-download-page
branch
from
3f576f3
to
0d1f6ba
Compare
robinandeer
approved these changes
Sep 2, 2022
simonauner
deleted the
GRW-1392/feat/add-switching-notice-for-download-page
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
sizeprop inNoticecomponent size font-sizes and paddings differ between Offer page and Download page. I'd prefer a lookup table if there were more than two sizes, now it felt like it just got too many variables to just hold two values in all the places where it'ssize === 'sm' ? ...Why?
Ticket(s): GRW-1392
size="sm":size="md":size="md"on a small screen:Download page: