Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Filter - filtering on NULL values broke #1065

Closed
thadin opened this issue Jun 18, 2020 · 3 comments
Closed

Quick Filter - filtering on NULL values broke #1065

thadin opened this issue Jun 18, 2020 · 3 comments

Comments

@thadin
Copy link

thadin commented Jun 18, 2020

Steps to reproduce this issue

  1. Right click in a data grid
  2. Select Quick Filter
  3. Select in the middle section (that generally requires input) either IS NULL or IS NOT NULL

Current behavior

Since a few updates back, these filter options require me to enter an input. Regardless of what input I give, nothing happens.

Expected behavior

The selected quick filter IS (NOT) NULL being applied to the column you right clicked on, without asking me for an input.

Environment

  • HeidiSQL version: 11.0.0.6013 (64 Bit)
  • Database system and version: MySQL 5.7.29
  • Operating system: Windows 10 (1903)

I'm using the dark Material theme.

@ansgarbecker
Copy link
Collaborator

Related to #444, for which I seem to have broken these both NULL filters.

@yphastos
Copy link

yphastos commented Jul 9, 2020

Sorry to post into a closed bug but I think is a minor issue not needing a new bug.

In my opinion, in the quick filter options, the icons in IS NULL and IS NOT NULL options should be interchanged:

image

IS NULL should be the dashed circle as in an empty field
and IS NOT NULL should be the solid line circle, as in having content.

also, the last option with a red cross is empty and thus confusing, it should say something like 'clear filters'

image

ansgarbecker added a commit that referenced this issue Jul 10, 2020
…ters, and fix empty "remove filter" caption
@ansgarbecker
Copy link
Collaborator

Confirmed - and just fixed both of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants