New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal scrolling in grids #142

Closed
penCsharpener opened this Issue Feb 16, 2018 · 11 comments

Comments

Projects
None yet
3 participants
@penCsharpener

penCsharpener commented Feb 16, 2018

Current behavior

  • mouse wheel without function key pressed scrolls up and down a table
  • mouse wheel with shift pressed moves the selected row/cell
  • mouse wheel with ctrl pressed zooms the table
  • mouse wheel with alt is just normal scrolling

Expected behavior

  • horizontally scrolling with mouse wheel is somehow possible
  • avoids having to use the scroll bar with the mouse pointer

Possible solution

  • I don't think it's wise to change present/establish functionality but I'd like horizontal scrolling of a table with lots of columns with shift + mouse wheel. Since it's already used alt + mouse wheel would work as well

Environment

  • HeidiSQL version:
    9.5.0.5248
  • Operating system:
    Windows 10 1709
@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 16, 2018

I'm confused. Are you sure you did not mix up vertical with horizontal?

@penCsharpener

This comment has been minimized.

penCsharpener commented Feb 16, 2018

🤦‍♂️ totally! I will correct it. maybe it's time for me to be horizontal now ;-) 🛌

@penCsharpener penCsharpener changed the title from enhancement: vertical scrolling in Data tab and queries to enhancement: horizontal scrolling in Data tab and queries Feb 16, 2018

@lukinhaspm

This comment has been minimized.

lukinhaspm commented Feb 17, 2018

hello @penCsharpener ! If you click with the mouse wheel, you can roll to up, down and both sides... your idea to use ctrl or shift will n direction with other mouse wheel functions (like zoon)

@ansgarbecker ansgarbecker changed the title from enhancement: horizontal scrolling in Data tab and queries to Horizontal scrolling in grids Feb 17, 2018

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 17, 2018

Alt + MouseWheel is indeed unused currently, so I should add that.

Also note, that if a grid has only a few rows fitting to your vertical space, then your mouse wheel already scrolls horizontally. But of course this issue is about scrolling horizontally when there are more rows than the screen has vertical space for.

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 18, 2018

The next build should work with Alt+Mousewheel in all grids.

@penCsharpener

This comment has been minimized.

penCsharpener commented Feb 18, 2018

wow, that was fast. looking forward to the next nightly.
thanks a lot for this!

@penCsharpener

This comment has been minimized.

penCsharpener commented Feb 18, 2018

Just tested it and it works well. It's a great addition.

However out of curiosity, what is the use case for the current behaviour of shift + mouse wheel?
I'm asking because shift usually represents the reverse of another short cut (alt + tab to go through opened Windows applications and shift + alt + tab to go through the same list in the opposite direction). Swapping shift + mouse wheel and alt + mouse wheel might make more sense to new users.

I would think it more natural if the horizontal scrolling would be shift + mouse wheel since that is also what some other tools do (Adobe Reader, Firefox, Chrome to name a few that even support it).

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 18, 2018

Revision: d60d3f3
Date: 11.12.2010 08:25:19
Message: Focus next or previous grid node on Shift+MouseWheel, in all trees. See http://www.heidisql.com/forum.php?t=7269

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 18, 2018

I'm with you with the "inversing functionality with shift" argument, as I'm personally also used to that. Probably I should switch the Alt logic with the Shift logic. What do you think?

@penCsharpener

This comment has been minimized.

penCsharpener commented Feb 18, 2018

Would be my preference as well. But I just read that forum post and if user AliG is now pretty used to the way it was that last 7 years then an option in preference would be in order. Default setting would be what it is now since that has a long history and optionally the user can switch around that logic.

@ansgarbecker

This comment has been minimized.

Collaborator

ansgarbecker commented Feb 18, 2018

To be honest, I don't think many users apart from that forum reporter knows about Shift+Mousewheel. So I guess switching these is a good idea.

ansgarbecker added a commit that referenced this issue Feb 18, 2018

Exchange shortcuts Shift+Mousewheel and Alt+Mousewheel, so Shift is f…
…or horizontal scrolling (inversing vertical scrolling), and Alt is for the more esoteric vertical-scrolling-with-focus-moving. See #142.

@ansgarbecker ansgarbecker added this to the v9.6 milestone Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment