Skip to content

Commit

Permalink
Remove apt-get clean in Dockerfile.{jetty,tomcat}
Browse files Browse the repository at this point in the history
Also manually cleaned up `/var/lib/apt/lists` in original commits but
got conflict with plantuml#97, then removed.

Ref:
https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

> In addition, when you clean up the apt cache by removing
> /var/lib/apt/lists it reduces the image size, since the apt cache is not
> stored in a layer.

> Official Debian and Ubuntu images automatically run apt-get clean,
> so explicit invocation is not required.
  • Loading branch information
PeterDaveHello authored and arnaudroques committed Apr 23, 2021
1 parent 9f0544c commit 7f2022a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Dockerfile.jetty
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ USER root

RUN apt-get update && \
apt-get install -y --no-install-recommends graphviz fonts-noto-cjk && \
apt-get clean && rm -rf /var/lib/apt/lists/*
rm -rf /var/lib/apt/lists/*

USER jetty

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.tomcat
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ MAINTAINER D.Ducatel

RUN apt-get update && \
apt-get install -y --no-install-recommends fonts-noto-cjk libexpat1 libcairo2 libpango1.0 libpangoft2-1.0 libpangocairo-1.0 && \
apt-get clean && rm -rf /var/lib/apt/lists/*
rm -rf /var/lib/apt/lists/*

ENV GRAPHVIZ_DOT=/usr/bin/dot

Expand Down

0 comments on commit 7f2022a

Please sign in to comment.