Force new Network after completing a step
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor, but currently when we step the event network we produce a new `Network`, but nothing forces this. `step` completes and returns a thunk containing the network, which gets stored in an `MVar`. This thunk isn't adding anything, so instead it would be better to just force the `Network`. We could do this either in `step` itself (as done in this commit), or we could force it when we store it the `s` `MVar`.
|
(I'm on mobile, otherwise I would look around myself) Does Network have strict fields? If not, I think we need more seqs n' bangs than just that one. :) |
|
Yep, it does indeed have strict fields already. |
mitchellwrosen
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor, but currently when we step the event network we produce a new
Network, but nothing forces this.stepcompletes and returns a thunk containing the network, which gets stored in anMVar. This thunk isn't adding anything, so instead it would be better to just force theNetwork. We could do this either instepitself (as done in this commit), or we could force it when we store it thesMVar.