Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when navigating through test cases #20

Closed
ChrisSchneebauer opened this issue Aug 13, 2018 · 1 comment
Closed

Crash when navigating through test cases #20

ChrisSchneebauer opened this issue Aug 13, 2018 · 1 comment
Labels
Milestone

Comments

@ChrisSchneebauer
Copy link

Hi,

you already mentioned this problem in the releas notes, but there's no issue logged. It would be great to get some more information, because I have this problem with nearly every Ctrl-click on a keyword. RIDE simply closes without any error.

When starting RIDE, the following error is shown in the console output. Is this related somehow?
Traceback (most recent call last):
File "C:\Users\vmuser\AppData\Local\Programs\Python\Python36\lib\site-packages\wx\core.py", line 2165, in Notify
self.notify()
File "C:\Users\vmuser\AppData\Local\Programs\Python\Python36\lib\site-packages\wx\core.py", line 3334, in Notify
self.result = self.callable(*self.args, **self.kwargs)
File "C:\Users\vmuser\AppData\Local\Programs\Python\Python36\lib\site-packages\robotide\editor\editors.py", line 154, in _collabsible_changed
self._store_settings_open_status()
File "C:\Users\vmuser\AppData\Local\Programs\Python\Python36\lib\site-packages\robotide\editor\editors.py", line 89, in _store_settings_open_status
self._settings.IsExpanded()
RuntimeError: wrapped C/C++ object of type Settings has been deleted

Some Package information, Python version 3.6.6:
pywin32 223.1
pywinauto 0.6.5
robotframework 3.0.4
robotframework-databaselibrary 1.0.1
robotframework-ride 1.7.2
wxPython 4.0.2

@2Eagle2
Copy link

2Eagle2 commented Nov 2, 2018

Perhaps I manage to find the issue.
This happends as the error say because it is too late to call the method to be called (the setting object is already destroyed)
robotide\editor\editors.py: 149

changing
wx.CallLater(200, self._collabsible_changed)
to
wx.CallAfter(self._collabsible_changed)

seems to fix the issue
(CallAfter call the function as soon as possible but after pending events so should be fine)

2Eagle2 added a commit to 2Eagle2/RIDE that referenced this issue Nov 2, 2018
change CallLater to CallAfter
@2Eagle2 2Eagle2 mentioned this issue Nov 2, 2018
HelioGuilherme66 pushed a commit that referenced this issue Nov 2, 2018
change CallLater to CallAfter

fix crash in wxpython caused by timer fired on GridWindow after it was destroyed
now the timer is stopped immediately after GridWindow is destroyed
@HelioGuilherme66 HelioGuilherme66 added this to the 1.7.3 milestone Nov 2, 2018
HelioGuilherme66 pushed a commit that referenced this issue Nov 2, 2018
change CallLater to CallAfter

fix crash in wxpython caused by timer fired on GridWindow after it was destroyed
now the timer is stopped immediately after GridWindow is destroyed
HelioGuilherme66 pushed a commit that referenced this issue Nov 2, 2018
* fix incorrect use of StringIO for Utf8Reader
fix incorrect incorrect deleting backup file - allow save changes

* fix focus detection on grid panel

* fix non working backspace key
when content of cell is deleted the whole cell is deleted

* fix wrong EOL

* fix wrong EOL

* fix issue #20
change CallLater to CallAfter

* fix crash in wxpython caused by timer fired on GridWindow after it was destroyed
now the timer is stopped immediately after GridWindow is destroyed

* fix EOL conversion

* delete debug print
HelioGuilherme66 pushed a commit that referenced this issue Jan 18, 2019
change CallLater to CallAfter
HelioGuilherme66 pushed a commit that referenced this issue Jan 18, 2019
change CallLater to CallAfter

fix crash in wxpython caused by timer fired on GridWindow after it was destroyed
now the timer is stopped immediately after GridWindow is destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants