Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added script to create .local.env for backend api url #42

Merged
merged 1 commit into from
May 21, 2023

Conversation

JoJoensuu
Copy link
Contributor

Closes #41
Added apiUrl variable to WeatherComponent.
Fixed docker-compose.yml to work.
Refactored backend Dockerfile.
Created script to generate .local.env with the backend api URL.
Production backend api url is in Github Actions Secrets.

@JoJoensuu JoJoensuu added this to the Sprint 0 milestone May 21, 2023
@JoJoensuu JoJoensuu self-assigned this May 21, 2023
isakpulkki

This comment was marked as duplicate.

isakpulkki

This comment was marked as duplicate.

Copy link
Contributor

@isakpulkki isakpulkki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend and backend works locally after running the script.

@isakpulkki isakpulkki merged commit db4c95e into main May 21, 2023
@JoJoensuu JoJoensuu deleted the jonij/weather-api-url branch May 22, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend calls backend URL correctly
2 participants