Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item view fix by Samuel #1

Closed
wants to merge 1 commit into from
Closed

Conversation

gepard-me
Copy link
Member

@gepard-me
Copy link
Member Author

As @MishimaHaruna said:

Hmm, doesn't look quite right to me, it's likely to break pre-re databases
columns matk, equip_level_min, equip_level_max aren't in the pre-re item_db.sql

@shennetsind
Copy link
Member

I never used Flux, my comment is based merely on what I see on the diff, I think:

  • changes the changes to themes/default/item/view.php could be ducked
  • the renewal checks that were removed in themes/default/item/index.php could be reversed, and add a new one for the 'MATK' field
  • in modules/item/view.php renewal checks would be needed in the new column types
  • in modules/item/index.php I don't have the foggiest :P

@jTynne
Copy link

jTynne commented Aug 3, 2013

Confirm @ breaks pre-RE; I think ossi posted a pre-RE compatible fix, and Samuel's makes RE-based servers work, but the code overall is wonky. I don't think the "RE Mode" in the config is working 100% as intended. Glad to see this is being looked into by the emulator, though!

@ghost ghost assigned gepard-me Aug 3, 2013
@gepard-me
Copy link
Member Author

I'll try to figure it out.

@gepard-me gepard-me closed this in 0567ebb Aug 3, 2013
@will21 will21 mentioned this pull request Nov 17, 2013
MishimaHaruna pushed a commit that referenced this pull request Dec 8, 2017
vietlubu pushed a commit to vietlubu/FluxCP that referenced this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants